-
Notifications
You must be signed in to change notification settings - Fork 159
chore(all): use upstream protocol params #966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanOppenheimer
approved these changes
Aug 5, 2025
alarso16
previously requested changes
Aug 5, 2025
ceyonur
reviewed
Aug 5, 2025
ceyonur
reviewed
Aug 5, 2025
JonathanOppenheimer
approved these changes
Aug 5, 2025
85865c7
to
ff947d8
Compare
JonathanOppenheimer
approved these changes
Aug 19, 2025
b28ae58
to
dc8cbd7
Compare
Signed-off-by: Jonathan Oppenheimer <[email protected]>
ceyonur
approved these changes
Aug 25, 2025
Signed-off-by: Jonathan Oppenheimer <[email protected]>
alarso16
approved these changes
Aug 25, 2025
didn't review, but merging as Cey reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Ported from subnet-evm's merged PR ava-labs/subnet-evm#1563
How this works
TestUpstreamParamsValues
is a change detector test to detect a geth params change in a future upgrade to make sure we take it into account.How this was tested
Existing CI passing
Need to be documented?
No
Need to update RELEASES.md?
No